[webkit-reviews] review denied: [Bug 49200] [Qt] bugs in Composition mode for QWebPage::inputMethodEvent & inputMethodQuery() : [Attachment 73374] fix style and changelog

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 49200: [Qt] bugs in Composition mode for QWebPage::inputMethodEvent &
inputMethodQuery()
https://bugs.webkit.org/show_bug.cgi?id=49200

Attachment 73374: fix style and changelog
https://bugs.webkit.org/attachment.cgi?id=73374&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73374&action=review

Oops,

> WebKitTools/ChangeLog:6
> +	   [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
> +	   https://bugs.webkit.org/show_bug.cgi?id=49047

This stuff belongs to another bug report :)

> WebKitTools/QtTestBrowser/mainwindow.cpp:119
> -    urlEdit->setText(url.toString(QUrl::RemoveUserInfo));
> +    setAddressUrl(url.toString(QUrl::RemoveUserInfo));

Ditto.

> WebKitTools/QtTestBrowser/mainwindow.cpp:125
> -    urlEdit->setText(url);
> +    if (!url.contains("about:"))
> +	   urlEdit->setText(url);

Ditto.