[webkit-reviews] review denied: [Bug 49200] [Qt] bugs in Composition mode for QWebPage::inputMethodEvent & inputMethodQuery() : [Attachment 73271] tested on both linux & s60

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 49200: [Qt] bugs in Composition mode for QWebPage::inputMethodEvent &
inputMethodQuery()
https://bugs.webkit.org/show_bug.cgi?id=49200

Attachment 73271: tested on both linux & s60
https://bugs.webkit.org/attachment.cgi?id=73271&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73271&action=review

Very nice test coverage here!
Unfortunately I have to r- because of lacking ChangeLog.

> WebKit/qt/ChangeLog:7
> +

Insufficient ChangeLog- please explain what's being changed and why.

> WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1695
> +    // clear selection, also cancel the ongoing composition if there is one

Comments should be capitalized and end with a period.

> WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1704
> +    //ImCurrentSelection

Style violation, space after //