[webkit-reviews] review denied: [Bug 49225] Philip Canvas test 2d.path.rect.winding fails : [Attachment 73312] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 9 00:18:40 PST 2010
Andreas Kling <kling at webkit.org> has denied Helder Correia
<helder at sencha.com>'s request for review:
Bug 49225: Philip Canvas test 2d.path.rect.winding fails
https://bugs.webkit.org/show_bug.cgi?id=49225
Attachment 73312: Patch
https://bugs.webkit.org/attachment.cgi?id=73312&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
This patch can be simplified to remove the "if (width < 0) {" and "if (height <
0) {" blocks and just leaving the Path::addRect() call as-is.
The Path objects generated by the two code paths in your patch are equivalent
AFAICT.
More information about the webkit-reviews
mailing list