[webkit-reviews] review denied: [Bug 49234] gtk platform doesn't support link prefetch : [Attachment 73336] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 19:43:27 PST 2010


Xan Lopez <xan.lopez at gmail.com> has denied Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 49234: gtk platform doesn't support link prefetch
https://bugs.webkit.org/show_bug.cgi?id=49234

Attachment 73336: Patch
https://bugs.webkit.org/attachment.cgi?id=73336&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>+AM_CONDITIONAL([ENABLE_LINK_PREFETCH],[test "$enable_link_prefetch" = "yes"])


I think you only need this if you are going to use the variable in a makefile.
Since you won't it's unneeded.

> 
> # Gtk conditionals
> AM_CONDITIONAL([ENABLE_INTROSPECTION],[test "$enable_introspection" = "yes"])

>@@ -1027,6 +1039,7 @@ Features:
>  XHTML-MP support					    : $enable_xhtmlmp
>  XPATH support					    : $enable_xpath
>  XSLT support 					    : $enable_xslt
>+ Link prefetch support				    :
$enable_link_prefetch

This should be in alphabetical order.

> GTK+ configuration:
>  GTK+ version 					    : $with_gtk
>  GDK target						    : $with_target

r- for those reasons, thanks for the patch.


More information about the webkit-reviews mailing list