[webkit-reviews] review granted: [Bug 48308] Too precise serialization from floating point number to string for "number" input elements : [Attachment 73333] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 19:11:23 PST 2010


Gavin Barraclough <barraclough at apple.com> has granted Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 48308: Too precise serialization from floating point number to string for
"number" input elements
https://bugs.webkit.org/show_bug.cgi?id=48308

Attachment 73333: Patch
https://bugs.webkit.org/attachment.cgi?id=73333&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
The patch looks great to me, setting r+ based on Kent's last comment.  

> I see. It's an issue to be considered, I think. I've created another bug
since it's a different issue from the bug 48308.
> https://bugs.webkit.org/show_bug.cgi?id=48976
> 
> For short, I guess it's not an issue of min/max checks, but an issue on
general steps from values in step-mismatching state.
> As written in the bug 48976, for the case <input type="number" step="1"
min="0" max="10.9" value="8.7" /> then stepUp(), I think the result should be 9
rather than 10. May I ask your opinion?

Dealing with the step mismatch as a separate bug seems sensible, re the change
in behavior, I'm not sure I have much of an opinion on this – it's quite a way
from my area of expertise – but your proposed change certainly sounds right to
me, seems intuitively like better behavior for stepUp to always take you to the
next step, never the next-but-one.

cheers,
G.


More information about the webkit-reviews mailing list