[webkit-reviews] review denied: [Bug 49115] Add custom bindings for AudioContext : [Attachment 73329] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 49115: Add custom bindings for AudioContext
https://bugs.webkit.org/show_bug.cgi?id=49115

Attachment 73329: Patch
https://bugs.webkit.org/attachment.cgi?id=73329&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73329&action=review

> WebCore/bindings/js/JSAudioContextCustom.cpp:40
> +	 return throwError(exec, createSyntaxError(exec, "AudioContext
constructor associated document is unavailable"));

The V8 bindings are throwing a ReferenceError, so to be consistent you should
do the same here and below.

> WebCore/bindings/js/JSAudioContextCustom.cpp:42
> +    Document* document =
static_cast<Document*>(jsConstructor->scriptExecutionContext());

>From looking at some of the other custom bindings, you need to check
ScriptExecutionContext::isDocument() before casting to Document* to be safe.
Since you're already doing the other checking you might as well do this too.