[webkit-reviews] review denied: [Bug 49223] dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html : [Attachment 73311] converted tests

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 49223: dump-as-markup conversion: editing/inserting/5607069-2.html and
5607069-3.html
https://bugs.webkit.org/show_bug.cgi?id=49223

Attachment 73311: converted tests
https://bugs.webkit.org/attachment.cgi?id=73311&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73311&action=review

> LayoutTests/editing/inserting/5607069-2.html:7
> +Markup.description("This tests for a bug where InsertLineBreak would insert
a '\\n' instead of a <br> if the caret was set just before an input field. You
should see two input fields each in its own paragraph below.");

We had better update the description text so that it mentions <br> between two
<input>s.

> LayoutTests/editing/inserting/5607069-3.html:7
> +Markup.description("This tests for a bug in InsertParagraph where it would
split and clone a <form> element in the same way it would a <p> or a <div>. 
You should see two paragraphs below both inside the form (blue bordered)
element.");

ditto. like "<br> between two x".
"blue border" seems to make no sense in dump-as-markup.