[webkit-reviews] review granted: [Bug 49151] [Chromium] REGRESSION(71474?) failing webkit tests on chromium canaries : [Attachment 73290] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 49151: [Chromium] REGRESSION(71474?) failing webkit tests on chromium
canaries
https://bugs.webkit.org/show_bug.cgi?id=49151

Attachment 73290: Patch
https://bugs.webkit.org/attachment.cgi?id=73290&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73290&action=review

> WebKitTools/ChangeLog:31
> +2010-11-07  Fumitoshi Ukai  <ukai at chromium.org>
> +
> +	   Unreviewed, rolling out r71475.

I don't think you meant to move Ukai's entry.

> WebKitTools/Scripts/webkitpy/common/system/filesystem_mock.py:55
> +    def isdir(self, path):
> +	   # FIXME: Implement :)
> +	   raise NotImplementedError

I'm still not a big fan of these stubs. :)

> WebKitTools/Scripts/webkitpy/common/system/filesystem_mock.py:77
> +		   exception = IOError()
> +		   exception.errno = errno.ENOENT
> +		   exception.filename = path
> +		   exception.strerror = "No such file or directory"

I bet there is a constructor...

> WebKitTools/Scripts/webkitpy/layout_tests/port/config.py:126
> +	   # Note: this code somewhat duplicates the code in
> +	   # scm.find_checkout_root(). However, that code only works if the top

> +	   # of the SCM repository also matches the top of the WebKit tree. The

> +	   # Chromium ports, for example, only check out subdirectories like
> +	   # WebKitTools/Scripts, and so we still have to do additional work
> +	   # to find the top of the tree.

I suspect lots of other pieces of webkitpy break for chromium too.