[webkit-reviews] review granted: [Bug 49195] webkit-patch failure-reason explodes if a build is missing : [Attachment 73276] Add a comment explaining why it might return None

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 14:03:14 PST 2010


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 49195: webkit-patch failure-reason explodes if a build is missing
https://bugs.webkit.org/show_bug.cgi?id=49195

Attachment 73276: Add a comment explaining why it might return None
https://bugs.webkit.org/attachment.cgi?id=73276&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73276&action=review

> WebKitTools/Scripts/webkitpy/common/net/buildbot.py:223
> +	       # It seems this can return None if the url redirects and then
returns 404.

Do other clients of this method need to understand that case?


More information about the webkit-reviews mailing list