[webkit-reviews] review requested: [Bug 48781] Add a resourceload delegate method to query if WebCore should paint the default broken image for failed images. : [Attachment 73268] New patch addressing review comments.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 8 12:42:58 PST 2010
Yongjun Zhang <yongjun_zhang at apple.com> has asked for review:
Bug 48781: Add a resourceload delegate method to query if WebCore should paint
the default broken image for failed images.
https://bugs.webkit.org/show_bug.cgi?id=48781
Attachment 73268: New patch addressing review comments.
https://bugs.webkit.org/attachment.cgi?id=73268&action=review
------- Additional Comments from Yongjun Zhang <yongjun_zhang at apple.com>
Change in this version:
1. added m_shouldPaintBrokenImage data member and getter/setter to
LayoutTestController, to turn on/off paint broken image for DRT.
2. added errorCode() member function in CachedImage as per review comments.
3. modified layout test to test if painting broken image is disabled.
More information about the webkit-reviews
mailing list