[webkit-reviews] review granted: [Bug 49189] We should add a build step to comment out or remove the lines unsetting TEMP and TMP in the .bashrc file : [Attachment 73252] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 49189: We should add a build step to comment out or remove the lines
unsetting TEMP and TMP in the .bashrc file
https://bugs.webkit.org/show_bug.cgi?id=49189

Attachment 73252: Patch
https://bugs.webkit.org/attachment.cgi?id=73252&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73252&action=review

> WebKitSite/building/tools.html:59
> +<p>If you are using a bash shell, comment out or remove the lines from your
.bashrc file (found at /home/[username]/.bashrc) that unset TMP and unset TEMP.
Those lines would prevent picking up the Windows TMP and TEMP environment
variables.</p>

I think it would be better to be more explicit. Something like:

Remove the following lines from <code>/home/[username]/.bashrc</code>:
<p class=code>unset TMP
unset TEMP</p>