[webkit-reviews] review granted: [Bug 49155] Remove the remaining editing-style functions from ApplyStyleCommand : [Attachment 73211] cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 10:43:40 PST 2010


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 49155: Remove the remaining editing-style functions from ApplyStyleCommand
https://bugs.webkit.org/show_bug.cgi?id=49155

Attachment 73211: cleanup
https://bugs.webkit.org/attachment.cgi?id=73211&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73211&action=review

Seems good. Refactoring looks like it was done correctly.

> WebCore/editing/EditingStyle.h:72
> +    void removeStyleAddedByNode(Node* node);
> +    void removeStyleConflictingWithStyleOfNode(Node* node);

No need for argument names here in these function declarations.


More information about the webkit-reviews mailing list