[webkit-reviews] review granted: [Bug 49137] [chromium] WebViewClient needs an API to report progress load : [Attachment 73189] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 10:34:19 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 49137: [chromium] WebViewClient needs an API to report progress load
https://bugs.webkit.org/show_bug.cgi?id=49137

Attachment 73189: Patch
https://bugs.webkit.org/attachment.cgi?id=73189&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73189&action=review

> WebKit/chromium/public/WebViewClient.h:122
> +    virtual void didMakeProgressLoading(WebFrame*, double loadProgress) { }

nit: perhaps didChangeLoadProgress would be a better name?  it matches the
parameter name.


More information about the webkit-reviews mailing list