[webkit-reviews] review denied: [Bug 48984] [Chromium] @media print crash due to paged media support : [Attachment 73225] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 04:22:31 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has denied Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 48984: [Chromium] @media print crash due to paged media support
https://bugs.webkit.org/show_bug.cgi?id=48984

Attachment 73225: Patch
https://bugs.webkit.org/attachment.cgi?id=73225&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73225&action=review

Looks like the expectation file is wrong?

> LayoutTests/printing/page-format-data-display-none-expected.txt:1
> +

Does DRT really output this file?

> WebCore/ChangeLog:6
> +	   https://bugs.webkit.org/show_bug.cgi?id=48984

I'd comment why this patch fixes this issue.


More information about the webkit-reviews mailing list