[webkit-reviews] review canceled: [Bug 49053] Refactoring: Return value of TextCheckingHelper::paragraphAlignedRange should form a class. : [Attachment 73207] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 04:14:12 PST 2010


MORITA Hajime <morrita at google.com> has canceled MORITA Hajime
<morrita at google.com>'s request for review:
Bug 49053: Refactoring: Return value of
TextCheckingHelper::paragraphAlignedRange should form a class.
https://bugs.webkit.org/show_bug.cgi?id=49053

Attachment 73207: Patch
https://bugs.webkit.org/attachment.cgi?id=73207&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
Hi Ryosuke, thank you for taking a look again!
I start thinking that how the class extracted is wrong and bad names imply
that.

it contains different concept:
- cached range related values
- relationship between two ranges
and each should have separate classes. So I'll investigate how to represent it.


More information about the webkit-reviews mailing list