[webkit-reviews] review granted: [Bug 47070] [Texmap] [Qt] Texture mapper initial implementation : [Attachment 73160] Prepare TextureMapper to be thread safe

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 47070: [Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Attachment 73160: Prepare TextureMapper to be thread safe
https://bugs.webkit.org/attachment.cgi?id=73160&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73160&action=review

> WebCore/platform/graphics/qt/TextureMapperQt.h:24
> +#define TextureMapperQt_h
> +namespace WebCore {

Add newline between these

> WebCore/platform/graphics/texmap/TextureMapperNode.cpp:35
> +	   inline int calculateCost() const

Rename to computeCost, to follow our nomenclature

> WebCore/platform/graphics/texmap/TextureMapperNode.cpp:81
> +	   m_totalCost += m_data[i].calculateCost();
> +
> +
> +    for (int i = size-1; i >= 0 && m_totalCost > TextureMapperCache::MaxCost
- TextureMapperCache::PurgeAmount; --i) {

Remove one of these newlines

> WebCore/platform/graphics/texmap/TextureMapperNode.cpp:193
> +	   return true;
> +    const int size = m_children.size();

Add newline between these two

> WebCore/platform/graphics/texmap/TextureMapperNode.cpp:207
> +	   return 0;
> +    int descendantsWithContent = (m_state.drawsContent ||
m_currentContent.contentType != HTMLContentType) ? 1 : 0;

here as well

> WebCore/platform/graphics/texmap/TextureMapperNode.cpp:329
> +	   return;
> +    m_transforms.forDescendants.setM13(0);

newline between