[webkit-reviews] review denied: [Bug 40887] requiredFeatures does not adapt to SVGStringList changes : [Attachment 73197] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied  review:
Bug 40887: requiredFeatures does not adapt to SVGStringList changes
https://bugs.webkit.org/show_bug.cgi?id=40887

Attachment 73197: Patch
https://bugs.webkit.org/attachment.cgi?id=73197&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73197&action=review

> WebCore/svg/SVGForeignObjectElement.cpp:88
> +    if (SVGTests::isKnownAttribute(attrName)) {
> +	   processTestAttributeChange();
> +	   return;
> +    }
> +

Okay, I have another nit-pick. I'd rather prefer to use:
if (SVGTests::handleAttributeChange(this, attrName))
     return;

SVGTests should have a "static void handleAttributeChange(SVGElement*
contextElement, const QualifiedName)" method.
That would look slightly better, and the code would be more encapsulated.