[webkit-reviews] review requested: [Bug 49152] Assert that a non-null Document has a non-null frame in Frame::setDocument() : [Attachment 73201] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 7 18:48:17 PST 2010


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 49152: Assert that a non-null Document has a non-null frame in
Frame::setDocument()
https://bugs.webkit.org/show_bug.cgi?id=49152

Attachment 73201: Patch
https://bugs.webkit.org/attachment.cgi?id=73201&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
This change does not cause any DRT regressions on my Mac.

As far as I can tell from looking at the callers of Frame::setDocument() and
the Document creation process, it doesn't make sense for Frame::setDocument()
to be passed a non-null PassRefPtr<Document> whose Document has a null frame
(i.e. Document::frame() == 0).


More information about the webkit-reviews mailing list