[webkit-reviews] review granted: [Bug 49136] [GTK] Wrapped DOM bindings GObjects do not disconnect event listeners when they die : [Attachment 73182] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 49136: [GTK] Wrapped DOM bindings GObjects do not disconnect event
listeners when they die
https://bugs.webkit.org/show_bug.cgi?id=49136

Attachment 73182: Patch
https://bugs.webkit.org/attachment.cgi?id=73182&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73182&action=review

Looks good to me.

> WebCore/bindings/gobject/GObjectEventListener.cpp:46
> +	   m_coreNode->addEventListener(domEventName, this, false);

There's no way you can have both right? There should be an else.

> WebCore/bindings/gobject/GObjectEventListener.h:51
> +

This should probably go in the impl. file?

> WebCore/bindings/gobject/GObjectEventListener.h:71
> +    // we only use them when the GObject and thus the WebCore object is
alive.

when the GObject... is created?