[webkit-reviews] review granted: [Bug 46335] Add EditingStyle : [Attachment 73014] fixed the crash on fast/events/keydown-function-keys.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 6 09:38:22 PDT 2010


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 46335: Add EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=46335

Attachment 73014: fixed the crash on fast/events/keydown-function-keys.html
https://bugs.webkit.org/attachment.cgi?id=73014&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73014&action=review

> WebCore/editing/EditingStyle.cpp:118
> +    m_mutableStyle = 0;

Should be nullptr rather than 0.

> WebCore/editing/EditingStyle.cpp:149
> +    RefPtr<EditingStyle> edtingStyle = EditingStyle::create(position);

Typo: "edting style".

> WebCore/editing/EditingStyle.h:43
> +class EditingStyle : public RefCounted<EditingStyle> {

To me it seems unhelpful to have EditingStyle be a reference counted object.
Since an editing style contains just one pointer to a reference counted object
and one boolean, it seems it could instead be a normal copyable object with
constructors instead of create functions. This would make it easier to program
with.

> WebCore/editing/EditingStyle.h:79
> +    void removeTextFillAndStroleColorsIfNeeded(RenderStyle*);

Typo: "strole colors"


More information about the webkit-reviews mailing list