[webkit-reviews] review granted: [Bug 49088] _bindResourceURL in ResourceManager.js may not add resource to map : [Attachment 73105] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Jenn Braithwaite
<jennb at chromium.org>'s request for review:
Bug 49088: _bindResourceURL in ResourceManager.js may not add resource to map
https://bugs.webkit.org/show_bug.cgi?id=49088

Attachment 73105: patch
https://bugs.webkit.org/attachment.cgi?id=73105&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73105&action=review

Thanks for fixing this!
Fyi: there is a webkit.com/new-inspector-bug that has nice template for
inspector bugs.

> WebCore/ChangeLog:5
> +	   _bindResourceURL in ResourceManager.js may not add resource to map

You should use Web Inspector: prefix

> WebCore/inspector/front-end/ResourceManager.js:405
> +	       var resourceForURLArray = [resourceForURL];

Nit: I would simply do

this._resourcesByURL[resource.url] = [resourceForURL, resource];