[webkit-reviews] review denied: [Bug 49118] Use IAccessibleComparable to compare accessibility objects. : [Attachment 73150] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 5 17:55:38 PDT 2010
chris fleizach <cfleizach at apple.com> has denied chris.guillory at google.com's
request for review:
Bug 49118: Use IAccessibleComparable to compare accessibility objects.
https://bugs.webkit.org/show_bug.cgi?id=49118
Attachment 73150: Patch.
https://bugs.webkit.org/attachment.cgi?id=73150&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73150&action=review
just one minor change, otherwise looks ok
> WebKitTools/DumpRenderTree/AccessibilityUIElement.h:-74
> -
i think we should remove the #if #else, then put this default implementation in
AccessibilutyUIElement.cpp as
#if !PLATFORM(WIN)
...
#endif
that way the header is easier to parse
More information about the webkit-reviews
mailing list