[webkit-reviews] review requested: [Bug 49106] Include the FrameView widget of a RenderWidget in the accessibility tree. : [Attachment 73138] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 5 16:32:42 PDT 2010


chris.guillory at google.com has asked  for review:
Bug 49106: Include the FrameView widget of a RenderWidget in the accessibility
tree.
https://bugs.webkit.org/show_bug.cgi?id=49106

Attachment 73138: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=73138&action=review

------- Additional Comments from chris.guillory at google.com
Before this patch the AX tree of the top document would not include any
children for a RenderIFrame render object (firstChild() doesn't return any
renderer children).

After this patch the AX tree of the top document will include the RenderView of
a RenderIFrame as a child. The RenderView document of the iFrame already
includes all of that document's children. Also calling
AccessibilityRenderObject::parentObject() on the RenderView document of an
iFrame will return the RenderIFrame of the parent document; previously calling
parentObject() repeatedly on a sub-document wouldn't walk all the way up to the
top document.


More information about the webkit-reviews mailing list