[webkit-reviews] review granted: [Bug 49096] JSCallbackData::invokeCallback triggers layout from a worker thread : [Attachment 73128] fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 5 15:15:53 PDT 2010


David Levin <levin at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 49096: JSCallbackData::invokeCallback triggers layout from a worker thread
https://bugs.webkit.org/show_bug.cgi?id=49096

Attachment 73128: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=73128&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73128&action=review

> WebCore/bindings/js/JSCallbackData.cpp:73
> +    if (context->isDocument())

It would be nice to not call this virtual function nearly twice in a row.
Consider storing the value in a bool and using in both places.


More information about the webkit-reviews mailing list