[webkit-reviews] review granted: [Bug 49066] Convert to and from DOMTimeStamp with converter functions : [Attachment 73072] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 49066: Convert to and from DOMTimeStamp with converter functions
https://bugs.webkit.org/show_bug.cgi?id=49066

Attachment 73072: Patch
https://bugs.webkit.org/attachment.cgi?id=73072&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73072&action=review

Thanks!  Much easier to understand.  :)

> WebCore/platform/android/GeolocationServiceAndroid.cpp:175
> -    DOMTimeStamp currentTimeMillis = WTF::currentTime() * 1000.0;
> -    DOMTimeStamp maximumAgeMillis = 10 * 60 * 1000;	// 10 minutes
> +    DOMTimeStamp currentTimeMillis =
convertSecondsToDOMTimeStamp(WTF::currentTime());
> +    DOMTimeStamp maximumAgeMillis = convertSecondsToDOMTimeStamp(10 * 60);
// 10 minutes

Should we rename these variables?  currentTimeStamp, etc?