[webkit-reviews] review granted: [Bug 48144] webkitpy: need a filesystem wrapper object for either mocking and dependency isolation : [Attachment 73010] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 48144: webkitpy: need a filesystem wrapper object for either mocking and
dependency isolation
https://bugs.webkit.org/show_bug.cgi?id=48144

Attachment 73010: Patch
https://bugs.webkit.org/attachment.cgi?id=73010&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73010&action=review

Thanks Dirk.  This looks great.

> WebKitTools/Scripts/webkitpy/common/system/filesystem_unittest.py:99
> +	       # Clean up.
> +	       os.rmdir(sub_path)

Do we want to use a finally here to make sure we clean up?  I'm not sure if
this is covered by the with statement.