[webkit-reviews] review granted: [Bug 46945] Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state : [Attachment 72995] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 4 16:17:13 PDT 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 46945: Make suspendAnimations/resumeAnimations and setCSSAnimations
traverse through subframes and remember state
https://bugs.webkit.org/show_bug.cgi?id=46945

Attachment 72995: Patch
https://bugs.webkit.org/attachment.cgi?id=72995&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72995&action=review

> LayoutTests/animations/animation-test-helpers.js:82
> +	   }
> +    }

inIframe is redundant, because you could just test if (iframeId)...

> LayoutTests/animations/stop-animation-on-suspend.html:56
> +	   setTimeout(suspend, 250);
> +	   setTimeout(resume, 500);

Can we make this test faster?


More information about the webkit-reviews mailing list