[webkit-reviews] review granted: [Bug 49033] webkitpy.common.system.executive_unittest fails when run with Win32 Python : [Attachment 72991] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 4 15:50:55 PDT 2010


David Levin <levin at chromium.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 49033: webkitpy.common.system.executive_unittest fails when run with Win32
Python
https://bugs.webkit.org/show_bug.cgi?id=49033

Attachment 72991: Patch
https://bugs.webkit.org/attachment.cgi?id=72991&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72991&action=review

Minor concern about possibly masking a failure with the roundtripping, but
otherwise this looks fine.

> WebKitTools/ChangeLog:37
> +	   be replaced by question marks; the round-tripping allows us to
expect

It sounds like this is a failure then?


More information about the webkit-reviews mailing list