[webkit-reviews] review granted: [Bug 48843] Web Inspector: [Chromium] Profiling must survive navigation : [Attachment 72826] profiles list in Inspector is now cleaned up on any reload, this simplifies code a lot

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 48843: Web Inspector: [Chromium] Profiling must survive navigation
https://bugs.webkit.org/show_bug.cgi?id=48843

Attachment 72826: profiles list in Inspector is now cleaned up on any reload,
this simplifies code a lot
https://bugs.webkit.org/attachment.cgi?id=72826&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72826&action=review

Lack of tests => sadness

> WebCore/inspector/InspectorController.cpp:677
> -void InspectorController::restoreProfiler()
> +void InspectorController::restoreProfiler(bool reset)

Consider using an enum rather than a bool here to make the call sites more
readable.