[webkit-reviews] review denied: [Bug 48812] FrameLoader::checkLoadCompleteForThisFrame uses wrong history item : [Attachment 72886] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Charles Reis <creis at chromium.org>'s
request for review:
Bug 48812: FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

Attachment 72886: Patch
https://bugs.webkit.org/attachment.cgi?id=72886&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72886&action=review

> WebCore/loader/FrameLoader.cpp:2385
> +		       // Do not change the history if the backForward
controller
> +		       // is aleady loading a new URL.
> +		       if (pdl->request().url() ==
page->backForward()->currentItem()->url()) {

URL can't be the right thing to use here.  What if all the pages in the
back-forward list have the same URL?  Wouldn't that case still have the
corruption?