[webkit-reviews] review denied: [Bug 48865] [GTK] Link with target name set does not work correctly : [Attachment 72955] Set global PageGroup name to all created pages

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 4 14:58:53 PDT 2010


Martin Robinson <mrobinson at webkit.org> has denied Nicolas Dufresne
<nicolas.dufresne at collabora.co.uk>'s request for review:
Bug 48865: [GTK] Link with target name set does not work correctly
https://bugs.webkit.org/show_bug.cgi?id=48865

Attachment 72955: Set global PageGroup name to all created pages
https://bugs.webkit.org/attachment.cgi?id=72955&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72955&action=review

Great! Is it possible to go one step further and remove
webkit_web_view_set_group_name from webkitwebview.cpp entirely, since, if I
understand correctly, it is now dead code.

> WebKit/gtk/webkit/webkitwebview.cpp:3250
> +    priv->corePage->setGroupName("WebKitGTK");

I think we should have a comment here explaining why this is necessary.


More information about the webkit-reviews mailing list