[webkit-reviews] review granted: [Bug 46417] Make tables work with vertical text : [Attachment 72899] Part 2: layout and painting

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted mitz at webkit.org's request for review:
Bug 46417: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Attachment 72899: Part 2: layout and painting
https://bugs.webkit.org/attachment.cgi?id=72899&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72899&action=review

r=me

> WebCore/rendering/RenderTable.h:60
> +	   return style()->isFlippedBlocksWritingMode() ? borderAfter() :
borderAfter();

This looks wrong.  One of them should be a borderBefore.

> WebCore/rendering/RenderTable.h:95
> +	   return style()->isFlippedBlocksWritingMode() ? outerBorderAfter() :
outerBorderAfter();

Same bug here.