[webkit-reviews] review granted: [Bug 49017] Title for images should use localized numerals : [Attachment 72973] Proposed patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Mike Thole <mthole at mikethole.com>'s request for
review:
Bug 49017: Title for images should use localized numerals
https://bugs.webkit.org/show_bug.cgi?id=49017

Attachment 72973: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=72973&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=72973&action=review

> WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm:666
> +    return [NSString localizedStringWithFormat:UI_STRING("%@ %@×%@ pixels",
"window title for a standalone image (uses multiplication symbol, not x)"),
(NSString *)filename, widthString, heightString];

Perhaps the localizer comment should mention that the first argument is a
filename (the may be helpful to localizers trying to decide what bidi embedding
characters to use and where).