[webkit-reviews] review requested: [Bug 26083] How to access formatted Java script Console message ? : [Attachment 72972] Patch against r71350, with fixes to issues raised by Lazlo. Layout tests also added.

[bugzilla-daemon at webkit.org]

Gopal Raghavan <gopal.1.raghavan at nokia.com> has asked  for review:
Bug 26083: How to access formatted Java script Console message ?
https://bugs.webkit.org/show_bug.cgi?id=26083

Attachment 72972: Patch against r71350, with fixes to issues raised by Lazlo.
Layout tests also added.
https://bugs.webkit.org/attachment.cgi?id=72972&action=review

------- Additional Comments from Gopal Raghavan <gopal.1.raghavan at nokia.com>
Patch based on r71350.
included console-api.html layout test.

Style check: PASS, LayoutTest:PASS

gopal at fire:~/WebKit1$ WebKitTools/Scripts/check-webkit-style 
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.h"
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp"
Total errors found: 0 in 11 files

gopal at fire:~/WebKit1$ WebKitTools/Scripts/run-webkit-tests --qt --debug -o
/tmp/layout/ LayoutTests/fast/dom/Window/console-functions.html 
Running build-dumprendertree
Running tests from /home/gopal/WebKit1/LayoutTests
Testing 1 test cases.
fast/dom/Window .
8.36s total testing time

all 1 test cases succeeded
gopal at fire:~/WebKit1$ WebKitTools/Scripts/run-webkit-tests --qt --debug -o
/tmp/layout/ LayoutTests/fast/dom/Window/console-api.html 
Running build-dumprendertree
Running tests from /home/gopal/WebKit1/LayoutTests
Testing 1 test cases.
fast/dom/Window .
11.32s total testing time

all 1 test cases succeeded