[webkit-reviews] review denied: [Bug 49008] Unbounded memory growth for long lived pages with many requests : [Attachment 72962] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 49008: Unbounded memory growth for long lived pages with many requests
https://bugs.webkit.org/show_bug.cgi?id=49008

Attachment 72962: Patch
https://bugs.webkit.org/attachment.cgi?id=72962&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72962&action=review

> WebCore/loader/Cache.cpp:802
> +SubCache::SubCache() :  m_cache(cache())

The ": m_cache(cache())" part should be on its own line and indented four
spaces.

> WebCore/loader/Cache.cpp:813
> +CachedResource*
> +SubCache::resourceForURL(const String &url) const

The return type should be on the same line as the function declaration.  Also,
I don't see where this function is called.

> WebCore/loader/Cache.cpp:825
> +void
> +SubCache::add(const String &url)
> +{
> +    if (m_cache->resourceForURL(url)) // It must be in the cache for it to
go into the subcache.
> +	   m_resources.add(url);
> +}

Where is this function called?

> WebCore/loader/Cache.h:241
> +class SubCache {

This should be in its own file.  Also, we should think of a more descriptive
name.

> WebCore/loader/Cache.h:243
> +public:
> +

No blank line here.