[webkit-reviews] review granted: [Bug 48969] Need a way to test in WebKit2 whether a form field contains marked text : [Attachment 72897] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 48969: Need a way to test in WebKit2 whether a form field contains marked
text
https://bugs.webkit.org/show_bug.cgi?id=48969

Attachment 72897: Patch
https://bugs.webkit.org/attachment.cgi?id=72897&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+    // Need to declare these attribute names because AppKit exports them but
does not make them available in API or SPI headers.
+    
+    extern NSString *NSMarkedClauseSegmentAttributeName;

This one is in 10.5 SDK.

+    extern NSString *NSTextInputReplacementRangeAttributeName;

This one is not - please file a bug, and reference it in a comment.

+    BOOL _isSelectionInPasswordField;

Since you added this, you probably already know that there is some advanced
trickery going on to make sure that password fields are handled correctly by
input methods. This is not relevant to this patch, but I wanted to be sure that
you look into that later.


+    Frame* frame =
m_page->corePage()->focusController()->focusedOrMainFrame();
+    if (!frame)
+	 return;

Why ask for main frame if there is no focused one?

r=me