[webkit-reviews] review granted: [Bug 31718] Framework to show form validation message for invalid controls : [Attachment 72157] Patch 13 (more simplification. No Chrome changes)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 21:00:46 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 31718: Framework to show form validation message for invalid controls
https://bugs.webkit.org/show_bug.cgi?id=31718

Attachment 72157: Patch 13 (more simplification. No Chrome changes)
https://bugs.webkit.org/attachment.cgi?id=72157&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72157&action=review

ok.

> WebCore/html/ValidationMessage.cpp:55
> +    if (m_message.isEmpty()) { } // FIXME: Construct validation message UI.

Probably should just remove this, leaving just a FIXME.


More information about the webkit-reviews mailing list