[webkit-reviews] review denied: [Bug 48368] Update ProgressTracker when moving a frame between documents : [Attachment 72848] updated patch - fix compile error

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied Jenn Braithwaite
<jennb at chromium.org>'s request for review:
Bug 48368: Update ProgressTracker when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48368

Attachment 72848: updated patch - fix compile error
https://bugs.webkit.org/attachment.cgi?id=72848&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72848&action=review

Looks good!
One small iteration...

> WebCore/loader/ResourceLoadNotifier.cpp:167
> +    oldPage->progress()->completeProgress(identifier);

Could we add ASSERT documenting that new page and old page are guaranteed
different here? This code actually uses this assumptions (because otherwise it
immediately deletes the just-transfered 'identifier' from the progress
tracker).