[webkit-reviews] review denied: [Bug 48891] renderbufferStorage(DEPTH_STENCIL) shouldn't generate an error : [Attachment 72880] patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 48891: renderbufferStorage(DEPTH_STENCIL) shouldn't generate an error
https://bugs.webkit.org/show_bug.cgi?id=48891

Attachment 72880: patch
https://bugs.webkit.org/attachment.cgi?id=72880&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72880&action=review

Thanks for fixing this. The code and test look fine aside from one minor issue.
It's too bad we can't force testing on a configuration where
GL_EXT_packed_depth_stencil isn't actually supported. Are you going to take
care of the Chromium side changes or should I?

> WebCore/html/canvas/WebGLRenderingContext.cpp:160
> +	   m_isDepthStencilSupported =
extensions.contains("GL_EXT_packed_depth_stencil");

At this point the way to phrase this extension query is
m_context->getExtensions()->supports("GL_OES_packed_depth_stencil"). We're
supposed to be getting rid of the EXTENSIONS enum at the public API level in
https://bugs.webkit.org/show_bug.cgi?id=40316 and presumably from
GraphicsContext3D as well. (It will probably need to remain as a private enum
in Extensions3D.)