[webkit-reviews] review granted: [Bug 48955] CG use of WebKit image decoders crashes on some animated GIFs : [Attachment 72873] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 48955: CG use of WebKit image decoders crashes on some animated GIFs
https://bugs.webkit.org/show_bug.cgi?id=48955

Attachment 72873: Patch
https://bugs.webkit.org/attachment.cgi?id=72873&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72873&action=review

Please consider making a helper function.

> WebCore/platform/image-decoders/cg/ImageDecoderCG.cpp:38
> +    m_bytes = m_backingStore ?
reinterpret_cast<PixelData*>(CFDataGetMutableBytePtr(m_backingStore.get())) :
0;

What about a backingStoreAsBytes() method?  Seems this is a lot of code to
copy/paste.