[webkit-reviews] review granted: [Bug 48956] Implement NP_SetProperty : [Attachment 72875] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 48956: Implement NP_SetProperty
https://bugs.webkit.org/show_bug.cgi?id=48956

Attachment 72875: Patch
https://bugs.webkit.org/attachment.cgi?id=72875&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72875&action=review

> WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp:142
> +    // And release the value.
> +    releaseNPVariantValue(&propertyValue);

Makes me think we should have a smart pointer for NPVariant.