[webkit-reviews] review granted: [Bug 46417] Make tables work with vertical text : [Attachment 72859] Part 1: make column width allocation algorithms (auto and fixed) work with vertical layout

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted mitz at webkit.org's request for review:
Bug 46417: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Attachment 72859: Part 1: make column width allocation algorithms (auto and
fixed) work with vertical layout
https://bugs.webkit.org/attachment.cgi?id=72859&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72859&action=review

r=me

> WebCore/rendering/FixedTableLayout.cpp:223
> +    if (m_table->document()->inQuirksMode() &&
m_table->style()->width().isPercent() && maxWidth < TABLE_MAX_WIDTH)

Should this be m_table->style()->logicalWidth().isPercent()?

> WebCore/rendering/RenderTable.h:115
> -    int bordersPaddingAndSpacing() const
> +    int bordersPaddingAndSpacingInRowDirection() const
>      {
>	   return borderLeft() + borderRight() +
>		  (collapseBorders() ? 0 : (paddingLeft() + paddingRight() +
(numEffCols() + 1) * hBorderSpacing()));
>  

Did you want to go ahead and patch this or save it for another patch?  It's
using left/right border and padding still.