[webkit-reviews] review granted: [Bug 48918] Crashes in WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair() when deleting multiple lines of text. : [Attachment 72844] Proposed patch (v1)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted jpu at apple.com's request for review:
Bug 48918: Crashes in
WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair() when
deleting multiple lines of text.
https://bugs.webkit.org/show_bug.cgi?id=48918

Attachment 72844: Proposed patch (v1)
https://bugs.webkit.org/attachment.cgi?id=72844&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It’s extremely inefficient to use TextIterator’s node() function on every node
in a range you are iterating. The TextIterator::range() function is far more
efficient. We should probably have a comment about that in TextIterator.h and
perhaps even rename node() to deprecatedNode().

This code change is OK, but I worry that
removeSpellAndCorrectionMarkersFromWordsToBeEdited can be pathologically slow
with a large selection because of the use of TextIterator::node().