[webkit-reviews] review granted: [Bug 48758] Stale reference to JSDOMWindow in ScriptController::m_cacheableBindingObject : [Attachment 72851] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 48758: Stale reference to JSDOMWindow in
ScriptController::m_cacheableBindingObject
https://bugs.webkit.org/show_bug.cgi?id=48758

Attachment 72851: Patch
https://bugs.webkit.org/attachment.cgi?id=72851&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72851&action=review

Change seems OK, but I’m not convinced this is all that’s needed.

> WebCore/ChangeLog:8
> +	   associated with the m_cacheablebindingRootObject every time we clear
the

The m_cacheableBindingRootObject mechanism seems half-implemented and it’s not
clear to me that “cacheable” is a good concept for this.

This fixes one bug, but I think there are going to be other problems as well.

Lets not add this in WebKit2 and maybe we can dump it for good eventually.

> WebCore/bridge/runtime_root.h:72
> +    void updateGlobalObject(JSGlobalObject* globalObject);

No need for the argument name here.