[webkit-reviews] review denied: [Bug 48382] Autofilled form elements are assigned fixed background color but not text color : [Attachment 72295] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 12:15:02 PDT 2010


Adam Barth <abarth at webkit.org> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 48382: Autofilled form elements are assigned fixed background color but not
text color
https://bugs.webkit.org/show_bug.cgi?id=48382

Attachment 72295: Patch
https://bugs.webkit.org/attachment.cgi?id=72295&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72295&action=review

> WebCore/ChangeLog:9
> +	   No new tests. (OOPS!)

We're going to need a test for this patch.  I'm not sure how to write one, but
someone on #webkit should be able to help you.	Generally, we don't accept any
patches without tests.	In some sense, the tests are the most important part of
the patch.


More information about the webkit-reviews mailing list