[webkit-reviews] review denied: [Bug 48894] Fix canvas/philip/tests/2d.pattern.image.undefined.html : [Attachment 72840] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 11:15:11 PDT 2010


Darin Adler <darin at apple.com> has denied Matthew Delaney <mdelaney at apple.com>'s
request for review:
Bug 48894: Fix canvas/philip/tests/2d.pattern.image.undefined.html
https://bugs.webkit.org/show_bug.cgi?id=48894

Attachment 72840: Patch
https://bugs.webkit.org/attachment.cgi?id=72840&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72840&action=review

The test cases cover passing non-objects, but not passing objects of the wrong
type, which follows a different code path. I’d like to see tests covering all
the code changes?

What about drawImageFromRect?

> WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:272
> -    } else
> -	  return throwTypeError(exec);
> -    
> +    }
> +    setDOMException(exec, TYPE_MISMATCH_ERR);

This change looks wrong. It seems we will set the exception in cases where we
succeeded above. After those cases break out of their switch statements and
then fall out of the if statements.

Do we have test cases covering those? Are they failing with exceptions now? If
not, why not?


More information about the webkit-reviews mailing list