[webkit-reviews] review granted: [Bug 46191] Make collapsed borders in tables work with different block flows : [Attachment 72838] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted mitz at webkit.org's request for review:
Bug 46191: Make collapsed borders in tables work with different block flows
https://bugs.webkit.org/show_bug.cgi?id=46191

Attachment 72838: Patch
https://bugs.webkit.org/attachment.cgi?id=72838&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72838&action=review

r=me

> WebCore/rendering/RenderTableCell.cpp:666
> +CollapsedBorderValue RenderTableCell::collapsedLeftBorder() const
> +{
> +    if (table()->style()->isHorizontalWritingMode())
> +	   return table()->style()->isLeftToRightDirection() ?
collapsedStartBorder() : collapsedEndBorder();
> +    return table()->style()->isFlippedBlocksWritingMode() ?
collapsedAfterBorder() : collapsedBeforeBorder();

I would cache table()->style() in a local and then use it in the three places
where you acccess it.  Ditto for collapsedRight/Top/BottomBorder.

> WebCore/rendering/RenderTableCell.cpp:743
> +int RenderTableCell::borderHalfRight(bool outer) const
> +{
> +    if (table()->style()->isHorizontalWritingMode())
> +	   return table()->style()->isLeftToRightDirection() ?
borderHalfEnd(outer) : borderHalfStart(outer);
> +    return table()->style()->isFlippedBlocksWritingMode() ?
borderHalfBefore(outer) : borderHalfAfter(outer);

Same comment.  Cache table()->style() in a local.  Same for all of the
borderHalf*** functions.