[webkit-reviews] review requested: [Bug 28272] WINCE PORT: graphics files only for WINCE : [Attachment 72813] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 05:26:35 PDT 2010


Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 28272: WINCE PORT: graphics files only for WINCE
https://bugs.webkit.org/show_bug.cgi?id=28272

Attachment 72813: Patch
https://bugs.webkit.org/attachment.cgi?id=72813&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72603&action=review

>> WebCore/platform/graphics/wince/SharedBitmap.cpp:57
>> +	return result;
> 
> Ditto.
> 
> By using RefPtr::release you save an extra ref/deref.

Ohh, good to know.

>> WebCore/platform/graphics/wince/SharedBitmap.cpp:92
>> +	    DeleteObject(m_hbitmap);
> 
> I still think it would be good to use an OwnPtr for m_hbitmap.

Upps, missed this point.

>> WebCore/platform/graphics/wince/SharedBitmap.cpp:565
>> +HDC SharedBitmap::DCProvider::getDC(SharedBitmap* bmp, unsigned* key1)
> 
> key1 could just be key now.
> 
> Maybe this function should return an OwnPtr<HDC>...

They do nearly the same as GraphicsContext::getWindowsContext().
Maybe we should change them too?


More information about the webkit-reviews mailing list