[webkit-reviews] review granted: [Bug 39691] [Qt] GraphicsLayer: support tiling : [Attachment 72770] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 01:47:54 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 39691: [Qt] GraphicsLayer: support tiling
https://bugs.webkit.org/show_bug.cgi?id=39691

Attachment 72770: Patch
https://bugs.webkit.org/attachment.cgi?id=72770&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72770&action=review

LGTM

> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:52
> +#define GRAPHICS_LAYER_TILING_THRESHOLD 2000

Maybe this needs change on a mobile device? Did you check the iphone source
dump?


More information about the webkit-reviews mailing list