[webkit-reviews] review canceled: [Bug 48858] Web Inspector: native breakpoints aren't hit on navigation : [Attachment 72709] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 48858: Web Inspector: native breakpoints aren't hit on navigation
https://bugs.webkit.org/show_bug.cgi?id=48858

Attachment 72709: Patch.
https://bugs.webkit.org/attachment.cgi?id=72709&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72709&action=review

I see two changes here: first makes front-end responsible for assigning
breakpoint ids, second makes them survive commit load. Two questions:
- is the first part really related to the fix,
- i don't see where the breakpoint maps get into the state cookie which makes
me think that it won't stop upon renderer (inspector controller) change.

> WebCore/inspector/InspectorController.cpp:730
> +	       m_debuggerAgent->setPauseWhenAttached();

Should this be called in reuseFrontend?

> WebCore/inspector/InspectorDOMAgent.cpp:782
> +    m_breakpointToId.remove(breakpoint);

clean up m_idToBreakpoint here as well?